pgsql: Fix brain fade in previous pg_dump patch.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Fix brain fade in previous pg_dump patch.
Дата
Msg-id E1RvvrK-0008BH-Ls@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix brain fade in previous pg_dump patch.

In pre-7.3 databases, pg_attribute.attislocal doesn't exist.  The easiest
way to make sure the new inheritance logic behaves sanely is to assume it's
TRUE, not FALSE.  This will result in printing child columns even when
they're not really needed.  We could work harder at trying to reconstruct a
value for attislocal, but there is little evidence that anyone still cares
about dumping from such old versions, so just do the minimum necessary to
have a valid dump.

I had this correct in the original draft of the patch, but for some
unaccountable reason decided it wasn't necessary to change the value.
Testing against an old server shows otherwise...

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/54660723715df39ba2c1b71ee0c44012b3d63acc

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix brain fade in previous pg_dump patch.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix oversight in pg_dump's handling of extension configuration t