pgsql: Fix brain fade in previous pg_dump patch.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Fix brain fade in previous pg_dump patch.
Дата
Msg-id E1RvvrK-0008BF-M0@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix brain fade in previous pg_dump patch.

In pre-7.3 databases, pg_attribute.attislocal doesn't exist.  The easiest
way to make sure the new inheritance logic behaves sanely is to assume it's
TRUE, not FALSE.  This will result in printing child columns even when
they're not really needed.  We could work harder at trying to reconstruct a
value for attislocal, but there is little evidence that anyone still cares
about dumping from such old versions, so just do the minimum necessary to
have a valid dump.

I had this correct in the original draft of the patch, but for some
unaccountable reason decided it wasn't necessary to change the value.
Testing against an old server shows otherwise...

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e565eff45a7d2cec6148cb5942d24ad0ebfbb1af

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix pg_dump for better handling of inherited columns.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix brain fade in previous pg_dump patch.