pgsql: When building with LWLOCK_STATS, initialize the stats in LWLockW

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема pgsql: When building with LWLOCK_STATS, initialize the stats in LWLockW
Дата
Msg-id E1RugCf-0001l6-F8@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
When building with LWLOCK_STATS, initialize the stats in LWLockWaitUntilFree.

If LWLockWaitUntilFree was called before the first LWLockAcquire call, you
would either crash because of access to uninitialized array or account the
acquisition incorrectly. LWLockConditionalAcquire doesn't have this problem
because it doesn't update the lwlock stats.

In practice, this never happens because there is no codepath where you would
call LWLockWaitUntilfree before LWLockAcquire after a new process is
launched. But that's just accidental, there's no guarantee that that's
always going to be true in the future.

Spotted by Jeff Janes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/15ad6f1510f8979a39e4c39078c742b5fdb121ce

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c |   33 +++++++++++++++++++++++----------
1 files changed, 23 insertions(+), 10 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix postmaster to attempt restart after a hot-standby crash.
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: createuser: Disable prompting by default