Make executor's SELECT INTO code save and restore original tuple receiver.
As previously coded, the QueryDesc's dest pointer was left dangling
(pointing at an already-freed receiver object) after ExecutorEnd. It's a
bit astonishing that it took us this long to notice, and I'm not sure that
the known problem case with SQL functions is the only one. Fix it by
saving and restoring the original receiver pointer, which seems the most
bulletproof way of ensuring any related bugs are also covered.
Per bug #6379 from Paul Ramsey. Back-patch to 8.4 where the current
handling of SELECT INTO was introduced.
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/658ee0108637683216fb093b9f2c7e23bfd150c5
Modified Files
--------------
src/backend/executor/execMain.c | 20 +++++++++++++++-----
src/test/regress/expected/select_into.out | 25 +++++++++++++++++++++++++
src/test/regress/sql/select_into.sql | 15 +++++++++++++++
3 files changed, 55 insertions(+), 5 deletions(-)