Disallow SELECT FOR UPDATE/SHARE on sequences.
We can't allow this because such an operation stores its transaction XID
into the sequence tuple's xmax. Because VACUUM doesn't process sequences
(and we don't want it to start doing so), such an xmax value won't get
frozen, meaning it will eventually refer to nonexistent pg_clog storage,
and even wrap around completely. Since the row lock is ignored by nextval
and setval, the usefulness of the operation is highly debatable anyway.
Per reports of trouble with pgpool 3.0, which had ill-advisedly started
using such commands as a form of locking.
In HEAD, also disallow SELECT FOR UPDATE/SHARE on toast tables. Although
this does work safely given the current implementation, there seems no
good reason to allow it. I refrained from changing that behavior in
back branches, however.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/21538377ee6a0ee91f756726bd8b3de6d19fd20a
Modified Files
--------------
src/backend/executor/execMain.c | 64 +++++++++++++++++++++++++++++++++++----
1 files changed, 58 insertions(+), 6 deletions(-)