Re: Change copyObject() to use typeof_unqual
| От | Jelte Fennema-Nio |
|---|---|
| Тема | Re: Change copyObject() to use typeof_unqual |
| Дата | |
| Msg-id | DH3OUTBIFWX0.2SOLV96RA95I9@jeltef.nl обсуждение исходный текст |
| Ответ на | Re: Change copyObject() to use typeof_unqual (Peter Eisentraut <peter@eisentraut.org>) |
| Ответы |
Re: Change copyObject() to use typeof_unqual
|
| Список | pgsql-hackers |
On Fri, 13 Mar 2026 at 11:43, Peter Eisentraut <peter@eisentraut.org> wrote: > There is a failure on buildfarm member taipan because it uses an unusual > combination of gcc and clang (the gcc is much newer than clang). The > only sensible workaround I could think of is a hardcoded override based > on the clang version, as in the attached patch. If we can then start prefering typeof_unqual over __typeof_unqual__ in the configure check for CC, then I think I like this as a workaround. If not, then I'm starting to think that actually checking support for this feature for CLANG is probably easier to understand (and less fragile) than combining all of these tricks together. Attached is a patch to do so. This only does it for CLANG, not for CLANG compiling C++ files. Theoretically that could be necessary, but I couldn't find a C++ compiler that supports any spelling of typeof_unqual. So I'm not even sure we need the current CXX check for typeof_unqual, I think we could remove that too and always use the fallback. > And alternative is that > we decide that we don't want to support this combination, meaning that > we would effectively require that clang is approximately as-old-or-newer > than gcc. Given that Tom seems to have reproduced this on Fedora 40, it sounds like we should fix it.
Вложения
В списке pgsql-hackers по дате отправления: