Re: COMMENTS are not being copied in CREATE TABLE LIKE
| От | Matheus Alcantara |
|---|---|
| Тема | Re: COMMENTS are not being copied in CREATE TABLE LIKE |
| Дата | |
| Msg-id | DGD4G22LA094.N14CLBAAJ8C4@gmail.com обсуждение исходный текст |
| Ответ на | Re: COMMENTS are not being copied in CREATE TABLE LIKE (Jim Jones <jim.jones@uni-muenster.de>) |
| Список | pgsql-hackers |
On Thu Feb 12, 2026 at 12:33 PM -03, Jim Jones wrote: > > > On 12/02/2026 16:08, Fujii Masao wrote: >> On Thu, Feb 12, 2026 at 11:36 PM Matheus Alcantara >> <matheusssilv97@gmail.com> wrote: >>> The patch fix the issue and it seems correct to me. > > Thanks for the review! > >> The documentation [1] states that INCLUDING COMMENTS copies comments for >> the copied columns, constraints, and indexes. It does not mention copying >> comments on the table itself. Therefore, not copying table comments with >> INCLUDING COMMENTS does not appear to be a bug. That is, the proposed patch >> seems more like an improvement than a bug fix. > > Hmm, it seemed so obvious to me that I didn’t look more closely at the > documentation :) > Yeah, me too. I even checked if column comments was being created, but I still assume that table comments should also be copied. > Although I struggle to see the rationale for not > copying a table’s comment in a CREATE TABLE LIKE ... INCLUDING COMMENTS > statement, I have to agree that the documentation is quite clear about > this limitation, and therefore it cannot really be considered a bug. > That said, it may well be worth considering for a future release. > > What are your thoughts? > +1 for having this as a feature on a future release. -- Matheus Alcantara EDB: https://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: