Re: Minor cleanups in the SSL tests
От | Daniel Gustafsson |
---|---|
Тема | Re: Minor cleanups in the SSL tests |
Дата | |
Msg-id | DF560F2E-A524-420E-B8C8-D0B4C1875F0A@yesql.se обсуждение исходный текст |
Ответ на | Re: Minor cleanups in the SSL tests (Daniel Gustafsson <daniel@yesql.se>) |
Список | pgsql-hackers |
> On 17 May 2024, at 09:58, Daniel Gustafsson <daniel@yesql.se> wrote: > >> On 17 May 2024, at 07:57, Peter Eisentraut <peter@eisentraut.org> wrote: >> >> On 16.05.24 23:27, Daniel Gustafsson wrote: >>>> On 16 May 2024, at 11:43, Peter Eisentraut <peter@eisentraut.org> wrote: >>>> You might want to run your patch through pgperltidy. The result doesn't look bad, but a bit different than what youhad crafted. >>> Ugh, I thought I had but clearly had forgotten. Fixed now. >>>> append_conf() opens and closes the file for each call. It might be nice if it could accept a list. Or you can justpass the whole block as one string, like it was done for pg_ident.conf before. >>> The attached v2 pass the whole block as a here-doc which seemed like the best >>> option to retain readability of the config. >> >> Works for me. > > Thanks for review. Once the tree opens up for v18 I'll go ahead with this. This has now been pushed after a little bit of editorializing and another pgperltidy run. -- Daniel Gustafsson
В списке pgsql-hackers по дате отправления: