On Mon Jan 8, 2024 at 9:26 AM EST, jian he wrote:
> On Mon, Jan 8, 2024 at 8:44 AM Dian Fay <di@nmfay.com> wrote:
> > The `regexp_replace` summary in table 9.10 is mismatched and still
> > specifies the first parameter name as `string` instead of `source`.
> > Since all the other functions use `string`, should `regexp_replace` do
> > the same or is this a case where an established "standard" diverges?
>
> got it. Thanks for pointing it out.
>
> in functions-matching.html
> if I change <replaceable>source</replaceable> to
> <replaceable>string</replaceable> then
> there are no markup "string" and markup "string", it's kind of
> slightly confusing.
>
> So does the following refactored description of regexp_replace make sense:
>
> The <replaceable>string</replaceable> is returned unchanged if
> there is no match to the <replaceable>pattern</replaceable>. If there is a
> match, the <replaceable>string</replaceable> is returned with the
> <replaceable>replacement</replaceable> string substituted for the matching
> substring. The <replaceable>replacement</replaceable> string can contain
> <literal>\</literal><replaceable>n</replaceable>, where
> <replaceable>n</replaceable> is 1
> through 9, to indicate that the source substring matching the
> <replaceable>n</replaceable>'th parenthesized subexpression of
> the pattern should be
> inserted, and it can contain <literal>\&</literal> to indicate that the
> substring matching the entire pattern should be inserted. Write
> <literal>\\</literal> if you need to put a literal backslash in
> the replacement
> text.
That change makes sense to me! I'll see about the section refactoring
after this lands.