RE: [PATCH] Windows port add support to BCryptGenRandom

Поиск
Список
Период
Сортировка
От Ranier Vilela
Тема RE: [PATCH] Windows port add support to BCryptGenRandom
Дата
Msg-id CO2PR05MB2629900008A7CA14E52A00C2E3530@CO2PR05MB2629.namprd05.prod.outlook.com
обсуждение исходный текст
Ответ на [PATCH] Windows port add support to BCryptGenRandom  (Ranier Vilela <ranier_gyn@hotmail.com>)
Список pgsql-hackers
De: Michael Paquier
Enviadas: Quarta-feira, 18 de Dezembro de 2019 02:19
>This looks like a leftover of d9dd406, which has made the code to
>require C99.  As we don't support compilation with Windows XP and
>require Windows 7, we should be able to remove all the dance around
>MIN_WINNT in win32.h, don't you think?
It would be a good thing since there is no support for these old systems.
And whenever there is a patch that touches windows, someone could complain that it would be breaking something.

Can You help improve the support of BCryptoGenRandom?
I still have doubts about:
  1. This break MingW?
  2. Legacy API, have to stay?
  3. Perl support, pgbench specifically.

If legacy API, have to stay, I have no doubt that it needs to be guarded by conditionals.


Best regards,

Ranier Vilela


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: RE: [Proposal] Level4 Warnings show many shadow vars
Следующее
От: Amit Kapila
Дата:
Сообщение: jacana seems to be failing in recoverycheck from last few runs