Re: Redundant/mis-use of _(x) gettext macro?
| От | Chao Li |
|---|---|
| Тема | Re: Redundant/mis-use of _(x) gettext macro? |
| Дата | |
| Msg-id | CE92DB56-4C12-4967-876C-CE2D79C98C67@gmail.com обсуждение исходный текст |
| Ответ на | Redundant/mis-use of _(x) gettext macro? (Peter Smith <smithpb2250@gmail.com>) |
| Список | pgsql-hackers |
> On Apr 1, 2026, at 11:48, Peter Smith <smithpb2250@gmail.com> wrote: > > Hi. > > As originally reported [1] in the EXCEPT (TABLE ...) thread, I felt > the _() gettext macro is mis-used when it contains nothing but a > quoted format string. > > AFAIK the purpose of using gettext (e.g. the "_(x)" macro) is for > marking the string for i18n translation. But there's nothing even to > translate here. Indeed. > > Only 2 examples were found like this. Granted, this is probably not > very harmful, but IMO it's better to patch the mis-use to prevent it > from propagating. +1 > > PSA the patch for more details. > > ====== > [1] https://www.postgresql.org/message-id/CAHut%2BPtVaOYVP1R0TOoNh5G9CUBurrP%3D6i7fJCdfWEZiqVCRvw%40mail.gmail.com > > Kind Regards, > Peter Smith. > Fujitsu Australia > <v1-0001-misuse-of-gettext-macro.patch> LGTM. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
В списке pgsql-hackers по дате отправления: