Re: [WIP PATCH] Index scan offset optimisation using visibility map

Поиск
Список
Период
Сортировка
От Andrey Borodin
Тема Re: [WIP PATCH] Index scan offset optimisation using visibility map
Дата
Msg-id CD3895DC-C15E-4B4F-9F47-53CCAB8E5B72@yandex-team.ru
обсуждение исходный текст
Ответ на [WIP PATCH] Index scan offset optimisation using visibility map  (Michail Nikolaev <michail.nikolaev@gmail.com>)
Ответы Re: [WIP PATCH] Index scan offset optimisation using visibility map
Список pgsql-hackers
Hi, Michail!

Thanks for the patch!

> 1 февр. 2018 г., в 1:17, Michail Nikolaev <michail.nikolaev@gmail.com> написал(а):
>
> Hello.
>
> WIP-Patch for optimisation of OFFSET + IndexScan using visibility map.

While the patch seems to me useful improvement, I see few problems with code:
1. Both branches of "if (node->iss_tuples_skipped_remaning != 0)" seem too similar. There is a lot of duplicate
commentset c. I think that this branch should be refactored to avoid code duplication. 
2. Most of comments are formatted not per project style.

Besides this, patch looks good. Please, add it to the following commitfest so that work on the patch could be tracked.

Best regards, Andrey Borodin.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Warning when building man pages
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: [HACKERS] A design for amcheck heapam verification