Re: Fix calloc check if oom (PQcancelCreate)

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Fix calloc check if oom (PQcancelCreate)
Дата
Msg-id CB73DAA5-6C1C-46D1-AD58-A213175B6938@yesql.se
обсуждение исходный текст
Ответ на Fix calloc check if oom (PQcancelCreate)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: Fix calloc check if oom (PQcancelCreate)  (Ranier Vilela <ranier.vf@gmail.com>)
Список pgsql-hackers
> On 27 May 2024, at 14:25, Ranier Vilela <ranier.vf@gmail.com> wrote:

> I think that commit 61461a3, left some oversight.
> The function *PQcancelCreate* fails in check,
> return of *calloc* function.
>
> Trivial fix is attached.

Agreed, this looks like a copy/paste from the calloc calls a few lines up.

> But, IMO, I think that has more problems.
> If any allocation fails, all allocations must be cleared.
> Or is the current behavior acceptable?

Since this is frontend library code I think we should free all the allocations
in case of OOM.

--
Daniel Gustafsson




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: relfilenode statistics
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: pgsql: Add more SQL/JSON constructor functions