Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:

Skip full index scan during cleanup of B-tree indexes when possible

Thank you for committing this.

It appears that patch contains some redundant variabled.  See warnings produced

by gcc-7.

nbtpage.c: In function '_bt_update_meta_cleanup_info':

nbtpage.c:121:15: warning: variable 'metaopaque' set but not used [-Wunused-but-set-variable]

  BTPageOpaque metaopaque;

               ^~~~~~~~~~

nbtree.c: In function '_bt_vacuum_needs_cleanup':

nbtree.c:790:15: warning: variable 'metaopaque' set but not used [-Wunused-but-set-variable]

  BTPageOpaque metaopaque;

               ^~~~~~~~~~

Attached patch fixes this.