Re: gistchoose vs. bloat

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема Re: gistchoose vs. bloat
Дата
Msg-id CAPpHfdvnW03Vs4SRK1LpF6dLWa9Z7MzkEidhAyNb6AuexwG87g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: gistchoose vs. bloat  (Jeff Davis <pgsql@j-davis.com>)
Ответы Re: gistchoose vs. bloat  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers
On Sun, Oct 21, 2012 at 11:03 AM, Jeff Davis <pgsql@j-davis.com> wrote:
On Thu, 2012-10-18 at 15:09 -0300, Alvaro Herrera wrote:
> Jeff, do you think we need more review of this patch?

In the patch, it refers to rd_options without checking for NULL first,
which needs to be fixed.

There's actually still one place where it says "id" rather than "is".
Just a nitpick.

Regarding my point 4 from the previous email, I mildly disagree with the
style, but I don't see a correctness problem there.

If the first two items are fixed, then the patch is fine with me.

First two items are fixed in attached version of the patch.

------
With best regards,
Alexander Korotkov.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: Proposal for Allow postgresql.conf values to be changed via SQL