On Tue, Jun 15, 2021 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > I did run "check-world", but it passed for me. Probably the same
> > reason it passed for some buildfarm animals...
>
> The only buildfarm animals that have passed since this went in
> are the ones that don't run the pg_dump or pg_upgrade tests.
>
> It looks to me like the proximate problem is that you should
> have taught pg_dump to skip these new auto-generated functions.
> However, I fail to see why we need auto-generated functions
> for this at all. Couldn't we have done it with one polymorphic
> function?
>
> I think this ought to be reverted and reviewed more carefully.
Thank you for your feedback. I've reverted the patch.
I'm going to have closer look at this tomorrow.
------
Regards,
Alexander Korotkov