Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()

On Fri, Jan 19, 2024 at 6:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Alexander Korotkov <akorotkov@postgresql.org> writes:
> > Reorder actions in ProcArrayApplyRecoveryInfo()
>
> I'm seeing this warning since this commit:
>
> procarray.c: In function 'ProcArrayApplyRecoveryInfo':
> procarray.c:1172:17: warning: declaration of 'xid' shadows a previous local [-Wshadow=compatible-local]
>    TransactionId xid = running->xids[i];
>                  ^~~
> procarray.c:1056:16: note: shadowed declaration is here
>   TransactionId xid;
>                 ^~~

Thank you for reporting.  Must be fixed in 448a3331d9.

------
Regards,
Alexander Korotkov