On Fri, Aug 16, 2024 at 12:19 AM Alexander Korotkov
<akorotkov@postgresql.org> wrote:
>
> Fix GetStrictOldestNonRemovableTransactionId() on standby
>
> e85662df44 implemented GetStrictOldestNonRemovableTransactionId() function
> for computation of xid horizon that avoid reporting of false errors.
> However, GetStrictOldestNonRemovableTransactionId() uses
> GetRunningTransactionData() even on standby leading to an assertion failure.
>
> Given that we decided to ignore KnownAssignedXids and standby can't have
> own running xids, we switch to use TransamVariables->nextXid as a xid horizon.
>
> Also, revise the comment regarding ignoring KnownAssignedXids with more
> detailed reasoning provided by Heikki.
I see the buildfarm failures. I will try to fix them shortly.
------
Regards,
Alexander Korotkov
Supabase