On Sun, Mar 3, 2024 at 1:50 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> On Mon, Nov 27, 2023 at 10:18 PM Mark Dilger
> <mark.dilger@enterprisedb.com> wrote:
> >
> > > On Nov 25, 2023, at 9:47 AM, Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > >
> > >> Should the patch at least document which parts of the EState are expected to be in which states, and which parts
shouldbe viewed as undefined? If the implementors of table AMs rely on any/all aspects of EState, doesn't that prevent
futurechanges to how that structure is used?
> > >
> > > New tuple tuple_insert_with_arbiter() table AM API method needs EState
> > > argument to call executor functions: ExecCheckIndexConstraints(),
> > > ExecUpdateLockMode(), and ExecInsertIndexTuples(). I think we
> > > probably need to invent some opaque way to call this executor function
> > > without revealing EState to table AM. Do you think this could work?
> >
> > We're clearly not accessing all of the EState, just some specific fields, such as es_per_tuple_exprcontext. I
thinkyou could at least refactor to pass the minimum amount of state information through the table AM API.
>
> Yes, the table AM doesn't need the full EState, just the ability to do
> specific manipulation with tuples. I'll refactor the patch to make a
> better isolation for this.
Please find the revised patchset attached. The changes are following:
1. Patchset is rebase. to the current master.
2. Patchset is reordered. I tried to put less debatable patches to the top.
3. tuple_is_current() method is moved from the Table AM API to the
slot as proposed by Matthias van de Meent.
4. Assert added to the table_free_rd_amcache() as proposed by Pavel Borisov.
------
Regards,
Alexander Korotkov