Hi!
On Wed, Aug 29, 2018 at 5:05 AM Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> At Tue, 28 Aug 2018 18:50:31 +0300, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote in
<CAPpHfduqEyyjLXCNx_t7K2ugCDGVW7WLKL+zrfDEd5wzkvmg-w@mail.gmail.com>
> > Also I found that this new pg_ctl isn't covered with tests at all. So
> > I've added very simple tap tests, which ensures that when log file was
> > renamed, it reappeared again after pg_ctl logrotate. I wonder how
> > that would work on Windows. Thankfully commitfest.cputube.org have
> > Windows checking facility now.
>
> Thanks for the test. Documentaion and help message looks fine
> including the changed ordering. (180 seconds retry may be a bit
> too long but I'm fine with it.)
Thank you for the comments. My idea about retry logic was to provide
the similar behavior to poll_query_until().
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company