Re: POC, WIP: OR-clause support for indexes

Hi, Richard!

On Mon, Nov 25, 2024 at 8:28 AM Richard Guo <guofenglinux@gmail.com> wrote:
> On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > I'm going to push this if no objections.
>
> Here is an Assert failure in match_orclause_to_indexcol.
>
> create table t (a int);
> create index on t (a);
>
> # explain select * from t where a <= 0 or a <= 1;
> server closed the connection unexpectedly
>
> The assertion is that the collected Const values cannot be NULL and
> cannot be zero.  The latter part about zero values doesn't make sense
> to me.  Why can't the values be zero?
>
>     Assert(!value->constisnull && value->constvalue);

Yes, this is a dumb assertion.  Removed.

------
Regards,
Alexander Korotkov
Supabase