Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun
Дата
Msg-id CAPpHfduOwLM-8DYu8j2hyF+bOvXhHCnNTjRA-KckxWot9B0sdQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Bug in ginRedoRecompress that causes opaque data on page to beoverrun  ("R, Siva" <sivasubr@amazon.com>)
Список pgsql-hackers
Дерево обсуждения
On Thu, Sep 6, 2018 at 9:02 PM R, Siva <sivasubr@amazon.com> wrote:
I'm also running into this assert with the workload, I think my patch is
not handling the case where the action is add items on the last segment
of the page correctly. I'm still investigating the issue further to find the
source of the bug.

Meanwhile I reviewed your patch and it looks good to me. I agree that
copying out the entire tail out to the scratch space in one shot vs copying
out every segment reduces the number of memcpy calls and simplifies
the solution overall. Let us go ahead with this patch.

Thank you for review!  Pushed with minor beautification.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: [HACKERS] Bug in to_timestamp().
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: [HACKERS] PATCH: multivariate histograms and MCV lists