On Tue, Jul 9, 2019 at 12:03 AM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
> On Mon, Jul 8, 2019 at 11:39 PM Nikita Glukhov <n.gluhov@postgrespro.ru> wrote:
> > On 08.07.2019 18:22, Alexander Korotkov wrote:
> > For me it doesn't look worth having two distinct functions
> > gist_box_distance_helper() and gist_bbox_distance(). What about
> > having just one and leave responsibility for recheck flag to the
> > caller?
> >
> > gist_bbox_distance() was removed.
>
> OK.
>
> > But maybe it would be better to replace two identical functions
> > gist_circle_distance() and gist_poly_distance() with the single
> > gist_bbox_distance()?
>
> Sounds reasonable to me.
However, gist_poly_distance() and gist_circle_distance() have
different signatures. Having same internal function to be
corresponding to more than one catalog function cause troubles in
sanity checks. So, let's leave it as it is.
Revised patchset is attached. It contains commit messages as well as
minor editorialization.
I'm going to push this if no objections.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company