Re: Unused argument in PinBuffer function

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема Re: Unused argument in PinBuffer function
Дата
Msg-id CAPpHfdsfxOS4XNhLuNgSkG=1KtsHrmwcUn+HdAcphRc+WUBrYw@mail.gmail.com
обсуждение исходный текст
Ответ на Unused argument in PinBuffer function  (Ildar Musin <i.musin@postgrespro.ru>)
Список pgsql-hackers
On Thu, Aug 4, 2016 at 2:28 PM, Ildar Musin <i.musin@postgrespro.ru> wrote:
I was looking through the buffer manager's code and have noticed that function PinBuffer has an unused 'strategy' argument. It's seems that after refactoring made by Alexander Korotkov and Andres Freund (48354581a49c30f5757c203415aa8412d85b0f70) it became useless. The attached patch removes it. Probably someone more advanced could edit the function description to reflect changes?

48354581 contain unintentional change that made 'strategy' argument of PinBuffer unused.
Since it was an unintentional change, it was decided to put old logic back.  See 9cf60332.
Thus, now 'strategy' argument of PinBuffer is used.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: logical replication launcher crash on buildfarm
Следующее
От: Jesper Pedersen
Дата:
Сообщение: Re: [POC] A better way to expand hash indexes.