On Mon, Sep 25, 2023 at 1:18 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
On Mon, Sep 25, 2023 at 12:58 PM Pavel Borisov <pashkin.elfe@gmail.com> wrote: > One more doubt about naming. Calling function > _bt_checkkeys(IndexScanDesc scan, IndexTuple tuple, int tupnatts, > ScanDirection dir, bool *continuescan, bool requiredMatchedByPrecheck) > as > (void) _bt_checkkeys(scan, itup, indnatts, dir, > &requiredMatchedByPrecheck, false); > looks little bit misleading because of coincidence of names of 5 and 6 > arguments.
I've added the comment clarifying this argument usage.
Fixed typo inficating => indicating as pointed by Pavel.
Peter, what do you think about the current shape of the patch?