On Fri, Jul 19, 2019 at 8:09 PM amul sul <sulamul@gmail.com> wrote:
> On Mon, Jul 8, 2019 at 5:03 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> I started reviewing this. Here is my initial review comments:
>>
>> * 0001-Hash-partition-bound-equality-refactoring-v22.patch
>> However, I don't think it's a good idea to do this
>> refactoring, because that would lead to duplicating the code to check
>> whether two given hash bound collections are equal in
>> partition_bounds_equal() and partition_hash_bounds_merge() that will
>> be added by the main patch, after all. To avoid that, how about
>> calling partition_bounds_equal() from partition_hash_bounds_merge() in
>> the main patch, like the attached?
> Agree, your changes look good to me, thanks for working on it.
Cool! Thanks for reviewing!
Sorry for the delay. I was busy with something else recently.
Best regards,
Etsuro Fujita