Re: [PATCH] ecpg: fix progname memory leak

Поиск
Список
Период
Сортировка
От John W Higgins
Тема Re: [PATCH] ecpg: fix progname memory leak
Дата
Msg-id CAPhAwGzcwASux9GtOFO5C36RYD6=pt9RNKtEt5CWyO-OALYrHw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] ecpg: fix progname memory leak  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: [PATCH] ecpg: fix progname memory leak  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers

On Wed, Oct 7, 2020 at 6:35 PM Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Oct 07, 2020 at 02:31:54PM +0300, Maksim Kita wrote:
> Fix progname memory leak in ecpg client.
> Issue taken from todo list https://wiki.postgresql.org/wiki/Todo.

FWIW, I don't see much point in doing that.  

I hope that everyone takes 10 seconds and realizes that this appears to be this person's first submitted patch. I would think a little more respect for the attempt to patch a minor issue would be afforded to such a person. Seems technically sound and they are not trying to change the world with their first attempt. 

Maybe a reminder that the TODO list is not always spectacular and that a double check with the list before doing something might be in order (in fact adding that to the top of the TODO list might be a great option here as well).

It's not going to win a Turing award - but I thought this project was a little more friendly then what I've seen in this thread towards a first time contributor.

John

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCH] ecpg: fix progname memory leak
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: [PATCH] ecpg: fix progname memory leak