Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

Поиск
Список
Период
Сортировка
От Shirley Wang
Тема Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
Дата
Msg-id CAPG3WN5J=OLySQkb4Q49-roTsh92F1HZPuj656XaUv53hVBz7A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Harshal and Akshay,

I'm noticing that the screenshots you attached have fonts that look different (ex. no font weights for table headers). Is that a result of the font bundling and needs to be updated?

On Fri, Sep 15, 2017 at 12:18 AM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Thanks, I'll look into it. 

On Sep 14, 2017 5:31 PM, "Akshay Joshi" <akshay.joshi@enterprisedb.com> wrote:
Hi Harshal 

I have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.

On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
It works, sorry for the noise.

On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Harshal, 

Can you please rebase the patch, it's not applied with the latest code.

On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Adding Akshay...

    Sure. 

On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review/commit this please?

On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Please find attached patch to represent array data in datagrid with curly braces and
also allow user to save array with values like  <null>, <empty string>, '""' and "''"

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Akshay Joshi
Principal Software Engineer 





--
Akshay Joshi
Principal Software Engineer 





--
Akshay Joshi
Principal Software Engineer 


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Harshal Dhumal
Дата:
Сообщение: Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]
Следующее
От: git@pgadmin.org
Дата:
Сообщение: pgAdmin 4 commit: Branch refs/heads/WEBPACK_DEVEL was created