Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls

Поиск
Список
Период
Сортировка
От Hitoshi Harada
Тема Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Дата
Msg-id CAP7QgmkUqymWHoiBkNnbW1zY=fgDOMyv2ruQfYHuagwuoQDhFQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls  (Nicholas White <n.j.white@gmail.com>)
Ответы Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls  (Nicholas White <n.j.white@gmail.com>)
Список pgsql-hackers


On Sat, Mar 23, 2013 at 3:25 PM, Nicholas White <n.j.white@gmail.com> wrote:
Thanks - I've added it here: https://commitfest.postgresql.org/action/patch_view?id=1096 .

I've also attached a revised version that makes IGNORE and RESPECT UNRESERVED keywords (following the pattern of NULLS_FIRST and NULLS_LAST).

Hm, you made another lookahead in base_yylex to make them unreserved -- looks ok, but not sure if there was no way to do it.

You might want to try byref types such as text.  It seems you need to copy the datum to save the value in appropriate memory context.  Also, try to create a view on those expressions.  I don't think it correctly preserves it.

Thanks,
--
Hitoshi Harada

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Atri Sharma
Дата:
Сообщение: Re: Page replacement algorithm in buffer cache
Следующее
От: Guillaume Lelarge
Дата:
Сообщение: Re: Problem with background worker