Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
| От | Mankirat Singh |
|---|---|
| Тема | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |
| Дата | |
| Msg-id | CAOtk82T=OO3e=SYPyHZq50wfyt569E6t=ee4b7va2y08M+a0SQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() ("David E. Wheeler" <david@justatheory.com>) |
| Ответы |
Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
|
| Список | pgsql-hackers |
On Sat, 18 Oct 2025 at 21:17, David E. Wheeler <david@justatheory.com> wrote:
>
> On Oct 18, 2025, at 11:14, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> > I am strongly against relying on suppression files. I think that
> > is a very imprecise technology, and it is certainly harder to use
> > than the "choose a blessed reference point" approach.
>
> Seconded. I’m also not keen on using something specific to libabigail if, long term, we want to enable similar checks on other platforms using other tools that may not support it suppression file format.
>
> Let’s do the baseline SHA file and see how it goes.
Oh right, I didn't think about the other platforms.
I've implemented the support for .abi-compliance-history file. If the file is present in a STABLE branch, it will be used by default; otherwise, the latest tag will be used. You can view the changes here[1].
Regards,
[1] - https://github.com/PGBuildFarm/client-code/pull/38/commits/f88873625ba0466e9609225947d40092748ff555
>
> On Oct 18, 2025, at 11:14, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> > I am strongly against relying on suppression files. I think that
> > is a very imprecise technology, and it is certainly harder to use
> > than the "choose a blessed reference point" approach.
>
> Seconded. I’m also not keen on using something specific to libabigail if, long term, we want to enable similar checks on other platforms using other tools that may not support it suppression file format.
>
> Let’s do the baseline SHA file and see how it goes.
Oh right, I didn't think about the other platforms.
I've implemented the support for .abi-compliance-history file. If the file is present in a STABLE branch, it will be used by default; otherwise, the latest tag will be used. You can view the changes here[1].
Regards,
Mankirat
В списке pgsql-hackers по дате отправления: