On Fri, Oct 29, 2021 at 8:59 AM Jeevan Ladhe <jeevan.ladhe@enterprisedb.com> wrote:> > bbsink_gzip_ops have the cleanup() callback set to NULL, and when the > bbsink_cleanup() callback is triggered, it tries to invoke a function that > is NULL. I think either bbsink_gzip_ops should set the cleanup callback > to bbsink_forward_cleanup or we should be calling the cleanup() callback > from PG_CATCH instead of PG_FINALLY()? But in the latter case, even if > we call from PG_CATCH, it will have a similar problem for gzip and other > sinks which may not need a custom cleanup() callback in case there is any > error before the backup could finish up normally. > > I have attached a patch to fix this.
Yes, this is the right fix. Apologies for the oversight.