Re: refactoring basebackup.c
От | Jeevan Ladhe |
---|---|
Тема | Re: refactoring basebackup.c |
Дата | |
Msg-id | CAOgcT0MNhJFWRBWLAYkOd4RcO9s7BKfdpy2txf=pC2SRA0JrxQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: refactoring basebackup.c (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>) |
Ответы |
Re: refactoring basebackup.c
|
Список | pgsql-hackers |
Hi Robert,
I have fixed the autoFlush issue. Basically, I was wrongly initializing
the lz4 preferences in bbsink_lz4_begin_archive() instead of
bbsink_lz4_begin_backup(). I have fixed the issue in the attached
patch, please have a look at it.
Regards,
Jeevan Ladhe
On Fri, Sep 24, 2021 at 6:27 PM Jeevan Ladhe <jeevan.ladhe@enterprisedb.com> wrote:
Still, there's got to be a simple way to make this work, and it can't
involve setting autoFlush. Like, look at this:
https://github.com/lz4/lz4/blob/dev/examples/frameCompress.c
That uses the same APIs that we're here and a fixed-size input buffer
and a fixed-size output buffer, just as we have here, to compress a
file. And it probably works, because otherwise it likely wouldn't be
in the "examples" directory. And it sets autoFlush to 0.Thanks, Robert. I have seen this example, and it is similar to what we have.I went through each of the steps and appears that I have done it correctly.I am still trying to debug and figure out where it is going wrong.I am going to try hooking the pg_basebackup with the lz4 source anddebug both the sources.Regards,Jeevan Ladhe
Вложения
В списке pgsql-hackers по дате отправления: