Re: Post-release followup: pg_add_size_overflow()

On Tue, Nov 18, 2025 at 5:17 PM Chao Li <li.evan.chao@gmail.com> wrote:
> I just reviewed the patch. Overall looks solid to me.

Thanks for the review!

> Putting “…” inside a function body looks quite uncommon. I searched over the source tree and couldn't find other
occurrence.As the comment has explained why omitting pg_neg_size_overflow, maybe just remove the entry #if 0 block, or
justleave an empty function body. 

My intent is just to document what the signature would have been. But
with Michael adding that it could confuse a casual grepper, I think
I'll switch to a standard comment, at minimum.

Thanks,
--Jacob