On Wed, Apr 17, 2019 at 1:55 PM Magnus Hagander <magnus@hagander.net> wrote:
>
> On Tue, Apr 16, 2019 at 5:39 PM Robert Treat <rob@xzilla.net> wrote:
>>
>> On Mon, Apr 15, 2019 at 3:32 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
>> >
>> > I don't know if that counts as an open item, but I attach a patch for
>> > all points discussed here.
>>
>> ISTM we should mention shared objects in both places in the docs, and
>> want "NULL if data checksums" rather than "NULL is data checksums".
>> Attaching slightly modified patch with those changes, but otherwise
>> LGTM.
Thanks, that's indeed embarassing typos. And agreed for mentioning
shared objects in both places.
>
> Interestingly enough, that patch comes out as corrupt. I have no idea why though :) v1 is fine.
>
> So I tried merging back your changes into it, and then pushing. Please doublecheck I didn't miss something :)
Thanks! I double checked and it all looks fine.