On Thu, Jul 30, 2020 at 3:54 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 29, 2020 at 06:35:41PM +0200, Julien Rouhaud wrote:
> > There's at least PREPARE TRANSACTION / COMMIT PREPARED / ROLLBACK
> > PREPARED that should be normalized too. I also don't think that we
> > really want to have different entries for begin / Begin / BEGIN /
> > bEgin and similar for many other commands, as the hash is computed
> > based on the query text.
>
> Hmm. Do we really want to those commands fully normalized all the
> time? There may be applications that care about the stats of some
> commands that are for example prefixed the same way and would prefer
> group those things together. By fully normalizing those commands all
> the time, we would lose this option.
>
> An example. The ODBC driver uses its own grammar for internal
> savepoint names, aka _EXEC_SVP_%p. If you mix that with a second
> application that has its own naming policy for savepoints it would not
> be possible anymore to make the difference in the stats between what
> one or the other do.
But if you have an OLTP application that uses ODBC, won't you already
have 80+% of pgss entries being savepoint orders, which is really not
helpful at all? We'd technically lose the ability to group such
commands together, but in most cases the current behavior is quite
harmful.