On Mon, Jun 22, 2020 at 5:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Julien Rouhaud <rjuju123@gmail.com> writes:
> > On Sun, Jun 21, 2020 at 4:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> 2. Text-format EXPLAIN output will grow double-quotes around the
> >> hypothetical index names, which are not there at present (I believe,
> >> but didn't test it). This shouldn't bother human users particularly,
> >> but conceivably it might break hypopg's regression tests?
>
> > Yes, the patch is working as expected. Before:
> > ...
> > All of the regression tests except the one I added when the fix for
> > brin hypothetical indexes was applied are still working, as they're
> > looking for patterns like "Index.*<\d+>${amname}_${relname}" in the
> > textual explain output. There are a few fixes not released yet, so
> > I'll update the broken brin regression test and publish a release soon
> > to make sure that the packages don't get broken when the new minor
> > versions are released.
>
> Doesn't sound too painful then. I pushed the patch to all branches;
> it should appear in 13beta2 this week, and in the August quarterly
> updates.
Great, thanks! I already pushed a fix for hypopg regression test, and
I confirm that everything works as intended, both with and without the
commit.