Hi Justin,
Thanks for the review!
On Sat, Apr 18, 2020 at 10:41 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> Should capitalize at least the non-text one ? And maybe the text one for
> consistency ?
>
> + ExplainPropertyInteger("WAL fpw", NULL,
I think we should keep both version consistent, whether lower or upper
case. The uppercase version is probably more correct, but it's a
little bit weird to have it being the only upper case label in all
output, so I kept it lower case.
> And add the acronym to the docs:
>
> $ git grep 'full page' '*/explain.sgml'
> doc/src/sgml/ref/explain.sgml: number of records, number of full page writes and amount of WAL bytes
>
> "..full page writes (FPW).."
Indeed! Fixed (using lowercase to match current output).
> Should we also change vacuumlazy.c for consistency ?
>
> + _("WAL usage: %ld records, %ld full page writes, "
> + UINT64_FORMAT " bytes"),
I don't think this one should be changed, vacuumlazy output is already
entirely different, and is way more verbose so keeping it as is makes
sense to me.