Re: pgAdmin IV : Unittest modular patch

Поиск
Список
Период
Сортировка
От Navnath Gadakh
Тема Re: pgAdmin IV : Unittest modular patch
Дата
Msg-id CAOAJCYqSdptT3Tyt+nNXxhMd5C2Z-u7yVM6TD4bUQUqE3nsQDg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pgAdmin IV : Unittest modular patch  (Dave Page <dave.page@enterprisedb.com>)
Ответы Re: pgAdmin IV : Unittest modular patch  (Dave Page <dave.page@enterprisedb.com>)
Список pgadmin-hackers
Hi Dave,
    Please find the updated patch for API unit test cases for Roles and Tablespaces nodes
As we finalized
Now,
   1. The user will specify the tablespace path in test_config.json.in
   2.  If tablespace path not found, skip the test cases for that server(Only tablespace test cases)
   3.  Add the skipped test summary in the test result. (Now it's showing on console + in log file, but need to update in a final enhanced test summary report. Which is research point we will work on that after finishing all nodes API test cases)
   4.  Removed the test_ prefix from the values in the config files.

Thanks!


On Thu, Aug 4, 2016 at 5:55 PM, Dave Page <dave.page@enterprisedb.com> wrote:
On Thu, Aug 4, 2016 at 1:02 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>
> On Thu, Aug 4, 2016 at 4:04 PM, Dave Page <dave.page@enterprisedb.com>
> wrote:
>>
>> Hi
>>
>> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
>> <navnath.gadakh@enterprisedb.com> wrote:
>>
>> >> Oh - does the per-server config override the main config? That's
>> >> useful. So anything that's in test_advanced_config.py can be
>> >> overridden on a per-server basis in test_config.py?
>> >
>> >     No.
>> >     per-server i.e advance config(test_advanced_config.json.in) and main
>> > config(test_config.json) both are different files. In main config we
>> > just
>> > mention the server’s credentials.(We can also mention per server
>> > credentails) and in test_advanced_config.json.in(here we say per-server
>> > config)
>> > we mention the advanced configurations i.e. test data for each node.
>>
>> OK.
>>
>> >     So, let's summarize the discussion:
>> >     - Let user specify the tablespace path in
>> > test_advanced_config.json.in
>>
>> No - test_config.py. It should be per-server.
>
>      We don't have a file named 'test_config.py' but we have a server's
> credential file named 'test_config.json'.
>      So, you are saying the tablespace path to be added in
> 'test_config.json'.
>      Am I correct?

Yeah, sorry. It should be a property of the server configuration.


--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878 


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Fix more of the funky keyboard shortcuts.