Re: pgAdmin4: Random failure of FTS test cases due to improper randomstring creation

On Fri, Aug 18, 2017 at 4:54 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote:

Hi Dave,

        Please find the attached patch for UUID creation issues with test objects for FTS configurations, FTS dictionaries and FTS parsers. Previously(refer email with subject "Build failed in Jenkins: pgadmin4-master-python27 #279" and "Build failed in Jenkins: pgadmin4-master-python33 #207"), test cases were randomly failing due to repetitions of the test object names.

In the old code we used some part of the string for creating a UUID string, but it seems that at some point that created string gets repeated and due to which test cases were failing as this was a random behavior, now it is fixed.

Navnath,

We're still not removing the temporary objects, created by test-cases, in the tear-down function.

We should have removed them in the tear-down function to fix the issue in proper way.

Dave - thoughts?

Right - it only seems to be FTS and FDW related objects that suffer from this problem from what I can see, so I assume we're getting it right for everything else by removing objects in the tear-down.

 

--

Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake