Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Дата
Msg-id CANxoLDfnxJJQ6j74zbZ7LT2aK7uKw49dbc=pZVxmOmNgEr=bog@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][SonarQube] Reduce cognitive complexity  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Thanks, patch applied.

On Wed, Aug 12, 2020 at 4:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix certain errors occurring when saving preferences. This is the regression of patch committed.
Please review.

On Tue, Aug 11, 2020 at 3:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Aug 11, 2020 at 11:42 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will reduce cognitive complexity for functions as below:
web/.../servers/pgagent/schedules/__init__.py - 17 to 15
web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15
web/pgadmin/setup/user_info.py - 22 to 15
web/pgadmin/utils/preferences.py - 29 to 15; 44 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fix PEP8
Следующее
От: Khushboo Vashi
Дата:
Сообщение: Re: str never has attribute decode in py3