Re: [pgAdmin4][Patch]: Psycopg3 Fixes

Поиск

Список

Период

Сортировка

От	Akshay Joshi
Тема	Re: [pgAdmin4][Patch]: Psycopg3 Fixes
Дата	21 октября 2022 г. 06:28:45
Msg-id	CANxoLDfV+qFjwtA8u4kYwAkXJEDHgJd+iD1=dr80HNQ3c6bJcw@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [pgAdmin4][Patch]: Psycopg3 Fixes (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы	Re: [pgAdmin4][Patch]: Psycopg3 Fixes (Akshay Joshi <akshay.joshi@enterprisedb.com>) Re: [pgAdmin4][Patch]: Psycopg3 Fixes (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список	pgadmin-hackers

Дерево обсуждения

Hi Khushboo

I think you forgot to add the python version check in the requirements.txt

psycopg2==2.9.*

psycopg==3.1.0

Builds are still failing.

Do we have checks inside the code that if psycopg3 is installed then call the API of psycopg3 else fallback to psycopg2? If not then we should add such checks.

On Fri, Oct 21, 2022 at 8:44 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, the patch applied to the psycopg3 branch

On Thu, Oct 20, 2022 at 2:40 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch which includes the inclusion of psycopg2 again. So, psycopg2 and psycopg3 both are supported. Also, it fixes some of the test cases which were failing. The debugger test cases fixes work is in progress.

Thanks,
Khushboo

--
Akshay Joshi
Principal Software Architect
+91 9767888246
www.enterprisedb.com