Attached is the patch to fix RM #3659 "Query tool does not give warning when Auto Commit is turned on in an incomplete transaction".
Please review it.
The behaviour doesn't seem quite right here. I see two issues:
1) It complains that a transaction is in progress if I try to turn auto-commit on in a freshly opened Query Tool. As I haven't done anything yet, I shouldn't get the warning. I think the logic to determine whether or not we're in a transaction isn't correct.
2) In the case above, the setting is changed anyway. I think this has the potential to be confusing (and potentially dangerous); we should only allow the setting to actually be toggled when there's no transaction in progress.
The above behaviour I have followed from pgAdmin 3.
Given 2), I wonder if we should remove the warning entirely, and just disable the menu options whenever a transaction is in progress.
Done. I have disabled the drop down button when transaction is in progress. I have tried to disabled single menu option but that is an anchor tag. I have tried with CSS by setting "pointer-events: none" and from HTML adding "disabled=’disabled’" which is only supported in old browsers.
Attached is the updated patch, please review it.
I've attached an updated patch - I started tweaking the messages, so please base additional work from that.