Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server
Дата
Msg-id CANxoLDeuUx3XL3=uHV6vN+wnjhjqa1OJBnR19da6VZYFqbCHmQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM5716] AJAX to generate the charts continues to fire after we disconnect the server  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Thanks, patch applied.

On Thu, Aug 6, 2020 at 2:32 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue mentioned in the subject.
Regarding hiding the color legend when the server is disconnected, I feel it's good to have the legend visible as it says it's a graph. Otherwise, a box with error is ambiguous. Plus, it's not going to change anyway even if graph data is available or not.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fixed an issue where ajax call continues to fire even
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: Code coverage report generation for JS files