Re: Feature #5370 User should be able to set the binary path for each database server

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: Feature #5370 User should be able to set the binary path for each database server
Дата
Msg-id CANxoLDeeYbPuZc4DPdsCMEEiPdwopM+cq0VOwsrahz1wvjZQNg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Feature #5370 User should be able to set the binary path for each database server  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Feature #5370 User should be able to set the binary path for each database server  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers


On Thu, May 13, 2021 at 3:09 PM Dave Page <dpage@pgadmin.org> wrote:
Hi Akshay,

On Thu, May 13, 2021 at 10:35 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya/Hackers

Screenshot 2021-05-13 at 3.02.59 PM.png

Are the above changes looks good? 

Well, s/Global/Default, but otherwise that, and the other UI is fine.

However, that does mean the path needs to be set for every server (and keep in mind, I know some users of this code have hundreds registered), and it also means that we cannot pre-configure the paths in, for example, our container.

    Yes, if the user wants to set it, else default path in the preferences is applicable. Yes, we can't pre-configure the paths. 

I'd prefer to see all the configuration in Preferences, so we'd maybe have a grid instead of a text field, containing three columns, one with the major version number, and one with the path to use for that version. The third column would be a radio button to mark a particular path as the default to use in case another path isn't set.
 
   OK, we need to create a new control for that which we can add into the Preferences. If I understand correctly initially the grid is empty, the user will have to add the major version (from the drop-down and that list contains values like 'PostgreSQL 10', 'PostgreSQL 11', 'EDB Advanced Server 10', .....) and respective path.
 


On Thu, May 13, 2021 at 2:43 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Just to make it more discoverable, please also change the help text in Preferences dialog.

On Thu, May 13, 2021 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave/Hackers

I have implemented feature #5370 "User should be able to set the binary path for each database server." I have added "Utility path" control in the Advanced tab of the server dialog, refer to the image below:

                          Screenshot 2021-05-13 at 2.11.52 PM.png

If the above path is set by the user then will pick that else we will pick the default binary path of the preferences dialog (if set). In case utility is not found on the specified path we raise the popup dialog with the modified error message. 

                         Screenshot 2021-05-13 at 2.12.28 PM.png

If the above implementation looks good then, I'll commit this feature by today's EOD.

--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Feature #5370 User should be able to set the binary path for each database server
Следующее
От: Dave Page
Дата:
Сообщение: Re: Feature #5370 User should be able to set the binary path for each database server