Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React
Дата
Msg-id CANxoLDe5mEx_pM85YarO_qeSa+_wOvThOuvPbtMfA3_3b4XhKw@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Ответы Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Nikhil

Following are the review comments:

GUI:
  • Dialog size should be increased.
  • Remove the first blank element from the Encoding dropdown.
  • When opening the file dialog header should have the title 'Select file'.
  • 'Backup server' title should be changed to 'Backup Server'.
  • When taking the backup of any object like database, schema, etc.. the title on the dialog header should be "Backup (Database/Schema ..." instead of  "Backup (database/schema ..."

Code:
  • Jasmine test cases are failing.
  • Remove warnBeforeChangesLost function not needed for Utilities. (Remove Alertify as well)
  • The naming convention should be identical, in some cases, you used camel case and in some cases used with an underscore.
  • Remove the commented code from all the files.
  • Take all the screenshots again with a width of 681.
Note: I haven't tested it thoroughly with all combinations.

On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for RM-6884:  Port Backup Global, Backup Server, and Backup object dialog in React


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Pradip Parkale
Дата:
Сообщение: [pgAdmin][RM6986]: Can't debug function with timestamp parameter
Следующее
От: Rahul Shirsat
Дата:
Сообщение: [patch][pgAdmin4] RM7006 With Python 3.10 eventlet==0.31.0 breaking the application