Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions
Дата
Msg-id CANxoLDduK0isJUAwFkp84jthXn7R9Tb_-y2E_u5TNxRCTCVV-g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Список pgadmin-hackers
Thanks, patch applied

On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay/Team,

I checked the code and found an issue in the "msql" function, due to which test cases were failing.
I have fixed the issue, PFA updated patch for the same.
Sorry for the inconvenience.


Regards,
Nikhil Mohite.



On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Nikhil

Test cases are failing for all the database server with the following error:
    return True, sql.strip('\n')
AttributeError: 'tuple' object has no attribute 'strip'

Please check and resend the patch.

On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have added few more test cases for the "Functions" module as per RM-5330
PFA patch.

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Improve code coverage and API test cases for Function
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: RM5841: server.username can be empty when using .pg_service.conf