Re: Fixed some compiler warnings
On Thu, Jan 30, 2014 at 7:35 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Thu, Jan 30, 2014 at 9:35 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi DaveI have fixed some compiler warnings which we are facing on OSX Mavericks. Attached is the patch file. Can you please review it.If patch looks good to you then can you please commit it.It mostly looks good, but what's with the operator changes? Why is it complaining about x >= 0 ?
In all such cases x is unsigned int and compiler complaining about condition "x >=0" will always true.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
В списке pgadmin-hackers по дате отправления: