Re: [RM- 4575] RE_SQL for Schema

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [RM- 4575] RE_SQL for Schema
Дата
Msg-id CANxoLDdZHmqPozanHujQtcdMdxhiwh-s1pguReVaq2jLYSv8HA@mail.gmail.com
обсуждение исходный текст
Ответ на [RM- 4575] RE_SQL for Schema  (Vishal Sawale <vishal.sawale@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Vishal

Following are my review comments:
  • Test cases for Schemas are not executing at all, we need to change the logic.
  • test.json file is not aligned properly.
  • Don't specify the namespaceowner/grantee/grantor as a hardcoded value to 'enterprisedb'.
  • Don't specify the hardcode value for "oid": 40970.  

On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale <vishal.sawale@enterprisedb.com> wrote:
Hi Hackers,

PFA the patch for RE-SQL test cases for Schema node. Please review.

Regards,
Vishal





--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: [pgAdmin] Remove hard-source-webpack-plugin
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Add support for OpenSSL 1.1.1 to the Windows installe