Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

Hi

On Thu, Apr 14, 2016 at 1:58 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi All 

I have fixed review comments given by Dave and couple of them are remaining

Fixed Review Comments:

• The View Data menu option should be on the Object menu, which should mirror the Context menu, except options should be disabled when not applicable instead of hidden.
  

• The Query Tool menu icon should be a glyphicon, to match the others.
  

• Please merge the functionality of the Refresh and Execute buttons into one button. We shouldn't have two buttons that do essentially the same thing.
  

• In Edit Grid mode, the History panel should log all queries (SELECTs, UPDATEs, DELETEs etc) as it would in the Query Tool.
  

• In Edit Grid mode, the Messages panel should display any messages from the most recent action  as it would in the Query Tool.
  

• In Edit Grid mode, that textbox should be read-only, but should display the SQL used (including any LIMIT/FILTER clauses)
  

• Please remove the border from the SQL box, such that it fills all available space.
  

• The Filter box should be in a modal overlay over the top of the SQL box/Results tabs as required. Those elements should be grayed whilst it is open.
  

• Please adjust the height of the Delete icon in the Edit Grid, such that it doesn't force the row height to be higher than it should be.
  
• I think the names of the tabs are far too long. Can we change them to "Query 1", "Query 2" etc, then rename them to the filename if the user saves/loads a file?
  

• We should add an "Edit" button, which opens a drop-down menu. This would eventually include options as found on the Edit menu in the pgAdmin3 query tool, such as the "Clear SQL" option.
  

• Ashesh and I discussed changing the History tab to be a grid, showing: Date/Time, Query (first line only), Rows affected, Runtime and Status, in a row per query executed. Ashesh suggested using a sub-form that can be expanded for each row, which could show the full query and error details (SQL State etc). New rows should be added to the top of the list.
  

• Errors should be highlighted in the SQL box - a marker in the margin to note the line, and spellcheck-style underlining for the error word.
  

• Query results should have spaces converted to "&nbsp;", so that proper indenting is maintained (for example, on EXPLAIN queries).
  
• on shutdown pgAdmin server , appropriate message should be displayed.