Re: [pgAdmin][RM3582] Can not add JSON-string as comments on objects

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM3582] Can not add JSON-string as comments on objects
Дата
Msg-id CANxoLDchSrG5WAvHGgw0SU_GRWs=pikjf6eoh=1=O0NkJ1cEBg@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM3582] Can not add JSON-string as comments on objects  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Thanks patch applied.

On Fri, Apr 12, 2019 at 1:19 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is to fix issue where adding JSON like comments on objects were considered as JSON instead of string, because of which the comments were altered at few places.

I have checked all the objects mentioned on https://www.postgresql.org/docs/current/sql-comment.html in pgAdmin and fixed wherever required. 

Please note, this patch also fixed RM4121 (a word change).

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: 1) Ensure that JSON strings as comments should be add
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Ensure we create a DMG file that's compatible with ma